Skip to content

[ROB-1896] Aws assume role bugfix#1914

Merged
Avi-Robusta merged 2 commits intomasterfrom
aws-assume-role
Sep 8, 2025
Merged

[ROB-1896] Aws assume role bugfix#1914
Avi-Robusta merged 2 commits intomasterfrom
aws-assume-role

Conversation

@Avi-Robusta
Copy link
Copy Markdown
Contributor

@Avi-Robusta Avi-Robusta commented Sep 8, 2025

prometrix 0.2.4 had release issues, bumping to 0.2.5

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Sep 8, 2025 •
edited
Loading

Walkthrough

Updated the default KRR image tag from v1.26.1 to v1.26.3 in krr.py and relaxed the prometrix dependency in pyproject.toml from a fixed 0.2.3 to a caret range ^0.2.5. No control flow or additional logic changes.

Changes

Cohort / File(s) Summary
KRR image default update
playbooks/robusta_playbooks/krr.py		 Changed global IMAGE default from {IMAGE_REGISTRY}/krr:v1.26.1 to {IMAGE_REGISTRY}/krr:v1.26.3; override via KRR_IMAGE_OVERRIDE unchanged.
Dependency version range adjustment
pyproject.toml		 Modified prometrix dependency from 0.2.3 to ^0.2.5 (>=0.2.5, <0.3.0).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • moshemorad
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f32b45c and d9928aa.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • playbooks/robusta_playbooks/krr.py (1 hunks)
  • pyproject.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: run_tests
  • GitHub Check: run_tests
🔇 Additional comments (2)
pyproject.toml (1)

62-62: Refresh lockfile and CI after bumping prometrix to ^0.2.5
0.2.5 is the latest 0.2.x release on PyPI; ensure your lockfile is regenerated and CI uses it so the AWS assume-role fix in 0.2.5 is applied.

playbooks/robusta_playbooks/krr.py (1)

39-39: Validate KRR image tag exists in registry
No IMAGE_REGISTRY value or inspection tool was detected in CI; please confirm that krr:v1.26.3 is available in your container registry before merging.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch aws-assume-role

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Avi-Robusta Avi-Robusta merged commit d169b2b into master Sep 8, 2025
6 checks passed
@Avi-Robusta Avi-Robusta deleted the aws-assume-role branch September 8, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nherment nherment nherment approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Avi-Robusta @nherment